feat(chain,wallet)!: Transitive ChainPosition
#1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
force-pushed
the
feature/transitive_chain_position
branch
from
374097d
to
1fb4428
Compare
Change `ChainPosition` to be able to represent transitive anchors and unconfirm-without-last-seen values.
evanlinjin
force-pushed
the
feature/transitive_chain_position
branch
from
1fb4428
to
368fed3
Compare
| /// | ||
| /// If the value is `Some`, it means we have incomplete data. We can only deduce that the | ||
| /// chain data is confirmed at a block equal to or lower than the block referenced by `A`. | ||
| transitively: Option<Txid>, |
There was a problem hiding this comment.
⛏️ I think calling the field either "child" or "descendant" would be best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
ChainPositionto be able to represent transitive anchors and unconfirm-without-last-seen values.As mentioned in #1670 (comment), we want this merged first so that we have minimal changes to the API after 1670 is merged.
Changelog notice
ChainPositionso that it is able to represent transitive anchors and unconfirmed-without-last-seen values.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
* [ ] I've added tests for the new feature